fix: defer interaction on birthday list command #13
Conversation
| const member = members.get(birthday.userID!); | ||
|
|
||
| if (member) { | ||
| monthBuckets[birthday.utcDatetime!.getUTCMonth()][1].push(`${member.displayName} - ${birthday.day}/${birthday.month} (Z${birthday.timezone! < 0 ? '' : '+'}${birthday.timezone})`); |
There was a problem hiding this comment.
Did you test that if a birthday has no utcDateTime? Does it then just add another array in the month buckets (which it can't due to it being const) or fail in some way?
There was a problem hiding this comment.
Birthday will always have a utcDateTime. It is populated in the setBrithday command. To be fair, these birthday commands could do with an update as they're just a port from the old bot.
Perhaps an update can be done in a future PR.
The whole thing is in a try catch, so if it happened it would be caught
There was a problem hiding this comment.
Just asking because of the !, since that's implying that there could be no utcDateTime.just don't know how the array is behaving with that, but since it's just copied from the old bot, it's fine with me
There was a problem hiding this comment.
Yes, if I remember the linting thought it could not exist. But, its ensured to exist in the other command therefore it does always exist. But in this file it doesn't know that
Description
Defers the interaction on birthday list command so the interaction doesn't time out when fetching a large amount of birthdays
Test Results
N/A
Discord Username
benw8484